Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jawn/sandbox v2 #252

Merged
merged 17 commits into from
Nov 29, 2023
Merged

Jawn/sandbox v2 #252

merged 17 commits into from
Nov 29, 2023

Conversation

jawndiego
Copy link
Contributor

updated to latest version of core PR entropyxyz/entropy-core#512

TODO: programs unit test has a socket hangs error.

all other tests pass.

@jawndiego jawndiego requested a review from frankiebee November 19, 2023 23:22
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third time is the charm 😉

please address review comments

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/keys/index.ts Outdated Show resolved Hide resolved
src/programs/index.ts Outdated Show resolved Hide resolved
src/programs/index.ts Outdated Show resolved Hide resolved
src/signing/index.ts Outdated Show resolved Hide resolved
tests/keys.test.ts Outdated Show resolved Hide resolved
tests/keys.test.ts Outdated Show resolved Hide resolved
tests/keys.test.ts Outdated Show resolved Hide resolved
tests/programs.test.ts Outdated Show resolved Hide resolved
@frankiebee
Copy link
Contributor

frankiebee commented Nov 20, 2023

const matchingAccount = /*{
  sigRequestKey: pair
  programModKey: pair,
}**/ genrateEntropyAccountFromSeed('seed')
const uniuqueAccount = /*{
  sigRequestKey: pair
  programModKey: pair,
}**/ genrateEntropyAccountFromSeeds({sigRequestSeed: 'seed', programModSeed'seeds'})


export interface EntropyAccout {
  sigRequestKey?: pair | string // if the sigRequestKey is a string or nothing. assume the entropy account is public 
  programModKey?: pair | string // if this is a string assume that the program modkey is externaly controlled
}


const opts = {
  account, // type EntropyAccount 
  endpoint,
} 


const entropy = new Entropy(opts)
// throws error if no default account is set & throws eeror if not accout provided
entropy.register({...normalParams, account?: EntropyAccout }) // again assume a pssed string is a public key. if nothing is provided use the default key on constructor

@jawndiego jawndiego requested a review from frankiebee November 20, 2023 20:33
* do checks on account keys

* keys adjustments. tests passing

* lint no longer displaying error

* formatting

* uncommented programModKeyPair validPair check

* updated documentation

* typo

---------

Co-authored-by: jawndiego <[email protected]>
frankiebee
frankiebee previously approved these changes Nov 28, 2023
@frankiebee frankiebee dismissed their stale review November 28, 2023 20:01

need a re rview

@jawndiego jawndiego requested a review from frankiebee November 28, 2023 20:11
frankiebee
frankiebee previously approved these changes Nov 28, 2023
Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me i say merger it in but lets be prepared for any unexpected side effects of making such a major architecture change

Copy link
Contributor

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures will be handled in separate PR. they are unrelated to this and are passing locally

@frankiebee frankiebee merged commit c7550a6 into master Nov 29, 2023
1 check failed
@frankiebee frankiebee deleted the jawn/sandbox_v2 branch November 29, 2023 18:09
@frankiebee frankiebee mentioned this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants