-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jawn/sandbox v2 #252
Jawn/sandbox v2 #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third time is the charm 😉
please address review comments
const matchingAccount = /*{
sigRequestKey: pair
programModKey: pair,
}**/ genrateEntropyAccountFromSeed('seed')
const uniuqueAccount = /*{
sigRequestKey: pair
programModKey: pair,
}**/ genrateEntropyAccountFromSeeds({sigRequestSeed: 'seed', programModSeed'seeds'})
export interface EntropyAccout {
sigRequestKey?: pair | string // if the sigRequestKey is a string or nothing. assume the entropy account is public
programModKey?: pair | string // if this is a string assume that the program modkey is externaly controlled
}
const opts = {
account, // type EntropyAccount
endpoint,
}
const entropy = new Entropy(opts)
// throws error if no default account is set & throws eeror if not accout provided
entropy.register({...normalParams, account?: EntropyAccout }) // again assume a pssed string is a public key. if nothing is provided use the default key on constructor |
* do checks on account keys * keys adjustments. tests passing * lint no longer displaying error * formatting * uncommented programModKeyPair validPair check * updated documentation * typo --------- Co-authored-by: jawndiego <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me i say merger it in but lets be prepared for any unexpected side effects of making such a major architecture change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, test failures will be handled in separate PR. they are unrelated to this and are passing locally
updated to latest version of core PR entropyxyz/entropy-core#512
TODO: programs unit test has a socket hangs error.
all other tests pass.